New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromJSON error while the json include popoutGroups #747

Closed

chhsgithub opened this issue Oct 31, 2024 · 1 comment · Fixed by #748

Milestone

chhsgithub commented Oct 31, 2024

Describe the bug
api.fromJSON error while the json include popoutGroups

To Reproduce
with my own code when the json layout includes popoutGroups, it will cause an error "Error: Invalid grid element"

with https://dockview.dev/demo/, by using save and then load/refresh will cause empty dock

action load
popout->layout changed->load->dock empty
https://github.com/user-attachments/assets/a3abe296-d534-43d9-8790-1fddbcaea1a9
action refresh
popout->layout changed->refresh browser tab->dock empty
https://github.com/user-attachments/assets/f7cd3cc9-a87f-4c2e-8556-3af8e9cea7e1

mathuo linked a pull request

that will close this issue

bug: duplicate .close() call #748

Merged

mathuo added this to the v2.0.0 milestone

mathuo closed this as completed in #748

mathuo reopened this

Owner

mathuo commented Nov 3, 2024

Released in 2.0.0. See https://github.com/mathuo/dockview/releases/tag/v2.0.0

mathuo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment