Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel Loses Content #472

Closed
sachnk opened this issue Jan 23, 2024 · 3 comments · Fixed by #474
Closed

Panel Loses Content #472

sachnk opened this issue Jan 23, 2024 · 3 comments · Fixed by #474
Milestone

Comments

@sachnk
Copy link
Contributor

sachnk commented Jan 23, 2024

Describe the bug
When closing a panel in a group, the content of other panels within the group is seemingly lost. This appears to happen with version 1.9.0 and up. This is happening after I upgraded to 1.9.0. When I downgrade to 1.8.5, the problem goes away.

To Reproduce
Here's a sandbox that reproduces this. This fork only modifies the content of the panel -- it simply adds "HELLO" to each panel.

Steps to reproduce the behavior:

  1. Go to sandbox
  2. Close 'Panel 1'
  3. See the "HELLO" text disappear on other panels within that group

Expected behavior
Content within a group should not be impacted by closing panels in that group.

Screenshots
dockview-bug

Desktop (please complete the following information):

  • Browser [e.g. chrome, safari]
    Chrome

  • Version [e.g. 22]
    119.0.6045.199

Additional context

@mathuo mathuo linked a pull request Jan 23, 2024 that will close this issue
@mathuo
Copy link
Owner

mathuo commented Jan 23, 2024

Sorry, this seems to be caused by changes to the rendering logic in 1.9.0 to handle multiple types of rendering options and has somehow slipped past the testing stage.

I will patch this today and get a 1.9.2 out.

PR raised here with a fix and tests, the documenation will be updated to render content in the panel to make this easier to spot too.

image

@mathuo mathuo reopened this Jan 23, 2024
@mathuo
Copy link
Owner

mathuo commented Jan 23, 2024

@sachnk Fix released in version 1.9.2

Thanks for the issue report! Hopefully all is fixed for you now.

@sachnk
Copy link
Contributor Author

sachnk commented Jan 24, 2024

@sachnk Fix released in version 1.9.2

Thanks for the issue report! Hopefully all is fixed for you now.

Yep, all good now... thanks for the quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants