Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyJsr250Destroyer should LOG instead of swallow and silently ignore Exception on close #13

Open
vorburger opened this issue Dec 14, 2016 · 0 comments

Comments

@vorburger
Copy link

This, where MyJsr250Destroyer just "swallows" (silently ignores) any Exception from @PreDestroy annotated methods, isn't great IMHO... it would be better if it would at least LOG.warn() such issues?

I suspect that you may be reluctant to make mycila/guice dependant on any particular logging framework, but I would argue that slf4j-api is meanwhile a nearly universally accepted logging API, with binding bridges to many others, and thus totally acceptable as a dependency.

Would a PR with this be welcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant