You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This, where MyJsr250Destroyer just "swallows" (silently ignores) any Exception from @PreDestroy annotated methods, isn't great IMHO... it would be better if it would at least LOG.warn() such issues?
I suspect that you may be reluctant to make mycila/guice dependant on any particular logging framework, but I would argue that slf4j-api is meanwhile a nearly universally accepted logging API, with binding bridges to many others, and thus totally acceptable as a dependency.
Would a PR with this be welcome?
The text was updated successfully, but these errors were encountered:
This, where MyJsr250Destroyer just "swallows" (silently ignores) any Exception from
@PreDestroy
annotated methods, isn't great IMHO... it would be better if it would at leastLOG.warn()
such issues?I suspect that you may be reluctant to make mycila/guice dependant on any particular logging framework, but I would argue that
slf4j-api
is meanwhile a nearly universally accepted logging API, with binding bridges to many others, and thus totally acceptable as a dependency.Would a PR with this be welcome?
The text was updated successfully, but these errors were encountered: