Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rp2040 support #31

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

ayushsharma82
Copy link

@ayushsharma82 ayushsharma82 commented Jun 13, 2024

Adds RP2040 support using AsyncTCP_RP2040W library.

Compiles fine but I'll do some actual tests soon.

@mathieucarbou
Copy link
Owner

mathieucarbou commented Jun 13, 2024

Thanks, reviewed, all fine.
Could you please also update the pio file and CI file ?
I'll merge after.

src/WebHandlers.cpp Outdated Show resolved Hide resolved
@mathieucarbou mathieucarbou marked this pull request as draft June 14, 2024 09:05
@mathieucarbou mathieucarbou force-pushed the rp2040 branch 9 times, most recently from 832118d to dbd738d Compare June 14, 2024 10:49
@mathieucarbou mathieucarbou marked this pull request as ready for review June 14, 2024 10:49
@mathieucarbou mathieucarbou marked this pull request as draft June 14, 2024 10:50
@mathieucarbou
Copy link
Owner

@ayushsharma82 so I am able to make it compile, there were also some errors due to the HTTP method enums. I've also updated the CI go through the pio file for pio and added a section for the rp2040.

I've set this PR to draft until you can correctly test it.

@mathieucarbou
Copy link
Owner

@ayushsharma82 : FYI I am changing the base branch to dev and will merge this PR to the dev branch.
You will be able to point to https://github.com/mathieucarbou/ESPAsyncWebServer#dev in your projects to test that.
Thanks!

@mathieucarbou mathieucarbou merged commit fa81ba7 into mathieucarbou:dev Jun 20, 2024
10 checks passed
mathieucarbou pushed a commit that referenced this pull request Sep 3, 2024
@MicSG-dev
Copy link

with the Raspberry Pi pico board (RP2040) without WiFi, but using the W5500 ethernet chip, it gives the following error: c:\Users\Michel\Documents\Arduino\libraries\AsyncTCP_RP2040W\src/AsyncTCP_RP2040W.h:73:4: error : #error For RASPBERRY_PI_PICO_W board using CYW43439 WiFi only 73 | #error For RASPBERRY_PI_PICO_W board using CYW43439 WiFi only | ^~~~~

@mathieucarbou
Copy link
Owner

@MicSG-dev : please open a new issue with your pio config (board, platfrom, etc).
From memory, there were a constraint for RPI boards regarding their support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants