Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Algorithms to be null but validate against algorithm of keyId's key otherwise #3

Open
noce2 opened this issue Mar 31, 2020 · 1 comment
Open

Allow Algorithms to be null but validate against algorithm of keyId's key otherwise #3

noce2 opened this issue Mar 31, 2020 · 1 comment

Comments

@noce2
Copy link
Contributor

noce2 commented Mar 31, 2020

user-account-service/src/main/java/io/mathdojo/security/HTTPRequestSignatureVerifier.java

Line 121 in 03ec795

String signatureAlgorithm = signatureValueContents.get(ALGORITHM_SIGNATURE_PARAM_KEY);

@noce2cicd noce2cicd changed the title : Allow Algorithms to be null but validate against algorithm of keyId's key otherwise Allow Algorithms to be null but validate against algorithm of keyId's key otherwise Mar 31, 2020
@noce2cicd
Copy link
Collaborator

This will enable compliance with spec as per: https://tools.ietf.org/html/draft-cavage-http-signatures-12#section-2.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noce2 @noce2cicd