Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework build scripts #9

Open
mateuszdrwal opened this issue Oct 18, 2023 · 0 comments
Open

Rework build scripts #9

mateuszdrwal opened this issue Oct 18, 2023 · 0 comments

Comments

@mateuszdrwal
Copy link
Owner

Currently, one can specify a build script that is ran when the challenge is built with a flag as a command line argument, allowing for the flag to only be defined in challenge.yaml. The intention has always been for build files to be committed to the challenge repository (so the builder doesn't have to replicate the same environment the problem author has to push challenges), and for the feature to only be used for inserting flags. I have though seen instances where people use this to just run make.

I'm not sure what the best way is to discourage actual builds in the build scripts. The name is very confusing for its purpose, so it should probably be renamed if it stays like this. Alternatively this could be replaced by a flag file option which just writes the flag to a specified path on build, but this prevents legitimate use cases of build scripts where the flag is built into the binary. Perhaps some sort of build docker container is in order, or the ability to copy out files from the image build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant