Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Date display/input format mismatch #370

Closed
Woebin opened this issue Nov 23, 2023 · 4 comments · Fixed by #376
Closed

[BUG] Date display/input format mismatch #370

Woebin opened this issue Nov 23, 2023 · 4 comments · Fixed by #376
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Woebin
Copy link

Woebin commented Nov 23, 2023

Describe the bug
Reading dates are shown in dd/mm/yyyy format, but when changing the date via input (i.e. not using the calendar element) it's parsed as mm/dd/yyyy.

To Reproduce

  1. Open details view on a book in your collection.
  2. Go into edit mode.
  3. Edit "finished reading" date.
  4. Hit the pen icon to switch from calendar view to manual input.
  5. Input date, e.g. "12/01/2020".
  6. "Finished reading" date is now set to the first of December, 2020, and displayed as "01/12/2020".

Expected behavior
Expected input format should match display format.

Screenshots
Will provide on requires if the description isn't clear enough.

Additional info(please complete the following information):

  • Manufacturer and model: OnePlus A6013
  • Android version: 11
  • App version: 2.2.0
  • App source (F-Droid, Google Play, Github): GitHub via Obtainium

Additional context
Ideally, date format should be up to the user and not locked into any default. Whichever format is used should be consistent throughout the app (input and display should match).

@Woebin Woebin added the bug Something isn't working label Nov 23, 2023
@ngocanhtve
Copy link
Contributor

Same issue for me

@magnus-ISU
Copy link

It would be nice if you could choose a date format, either

mm/dd/yyyy
dd/mm/yyyy
yyyy-mm-dd

@mateusz-bak
Copy link
Owner

mateusz-bak commented Nov 24, 2023

Dates are displayed dd/mm/yyyy in the app. When you edit the date manually through the picker I suppose it dynamically adjusts to your locale settings. I'll dig how to make that coherent

@mateusz-bak mateusz-bak added this to the Release 2.3.0 milestone Nov 24, 2023
@mateusz-bak
Copy link
Owner

Alright, from now on the displayed dates (in book screen, in the list etc) will follow devices format (same as the one in date picker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants