From 25f796ef3f4d3bfa529cdc4c31c864ca2f75dfe3 Mon Sep 17 00:00:00 2001 From: John de Wasseige Date: Thu, 2 Jan 2025 11:58:11 +0100 Subject: [PATCH 1/3] Remove is_rare_earth_metal from periodic_table.py --- src/pymatgen/core/periodic_table.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/pymatgen/core/periodic_table.py b/src/pymatgen/core/periodic_table.py index d3ae2e44d49..0b659b025ef 100644 --- a/src/pymatgen/core/periodic_table.py +++ b/src/pymatgen/core/periodic_table.py @@ -754,19 +754,6 @@ def is_rare_earth(self) -> bool: """ return self.is_lanthanoid or self.is_actinoid or self.symbol in {"Sc", "Y"} - @property - @deprecated( - is_rare_earth, - message="is_rare_earth is corrected to include Y and Sc.", - deadline=(2025, 1, 1), - ) - def is_rare_earth_metal(self) -> bool: - """True if element is a rare earth metal, Lanthanides (La) series and Actinides (Ac) series. - - This property is Deprecated, and scheduled for removal after 2025-01-01. - """ - return self.is_lanthanoid or self.is_actinoid - @property def is_metal(self) -> bool: """True if is a metal.""" From aade0533f139e97b468c9d0d6243cc8614797b27 Mon Sep 17 00:00:00 2001 From: John de Wasseige Date: Thu, 2 Jan 2025 12:26:44 +0100 Subject: [PATCH 2/3] Rm deprecated from monty --- src/pymatgen/core/periodic_table.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pymatgen/core/periodic_table.py b/src/pymatgen/core/periodic_table.py index 0b659b025ef..7bddfbe6dfd 100644 --- a/src/pymatgen/core/periodic_table.py +++ b/src/pymatgen/core/periodic_table.py @@ -14,7 +14,6 @@ from typing import TYPE_CHECKING, overload import numpy as np -from monty.dev import deprecated from monty.json import MSONable from pymatgen.core.units import SUPPORTED_UNIT_NAMES, FloatWithUnit, Ha_to_eV, Length, Mass, Unit From 30f03a26a2fcd36a5b7b6c0acae35d9fb22edc0a Mon Sep 17 00:00:00 2001 From: John de Wasseige Date: Thu, 2 Jan 2025 12:29:20 +0100 Subject: [PATCH 3/3] Rm is_rare_earth_metal from docs/pymatgen.md --- docs/pymatgen.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/pymatgen.md b/docs/pymatgen.md index a72f8e125bf..90f1e934b24 100644 --- a/docs/pymatgen.md +++ b/docs/pymatgen.md @@ -2454,7 +2454,6 @@ nav_order: 6 * [`ElementBase.is_noble_gas`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.is_noble_gas) * [`ElementBase.is_post_transition_metal`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.is_post_transition_metal) * [`ElementBase.is_quadrupolar`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.is_quadrupolar) - * [`ElementBase.is_rare_earth_metal`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.is_rare_earth_metal) * [`ElementBase.is_transition_metal`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.is_transition_metal) * [`ElementBase.is_valid_symbol()`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.is_valid_symbol) * [`ElementBase.iupac_ordering`](pymatgen.core.md#pymatgen.core.periodic_table.ElementBase.iupac_ordering)