Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling PhaseDiagram.as_dict() breaks the link between different Entries #3940

Open
CompRhys opened this issue Jul 19, 2024 · 0 comments
Open
Labels
enhancement A new feature or improvement to an existing one good first issue A new feature or bug fix suited for beginners to start contributing help wanted Help wanted

Comments

@CompRhys
Copy link
Contributor

CompRhys commented Jul 19, 2024

Feature Requested

When saving the PhaseDiagram it could reduce the memory footprint if to keep track of the ids of entries rather than just save multiple copies of entries in the separate lists.

Proposed Solution

Refactor the PhaseDiagram class to use @property to return the different lists of entries that are kept track of based on lists of ids as opposed to making references that result in duplication when serializing.

Relevant Information

This isn't a priority and would only be worth merging if the differences in speed are negligible. Posting this issue because it may be a good first issue for someone to tackle if I can't get round to it in the near term.

@CompRhys CompRhys added the enhancement A new feature or improvement to an existing one label Jul 19, 2024
@janosh janosh added good first issue A new feature or bug fix suited for beginners to start contributing help wanted Help wanted labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement to an existing one good first issue A new feature or bug fix suited for beginners to start contributing help wanted Help wanted
Projects
None yet
Development

No branches or pull requests

2 participants