Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvment] duplicated data selection from exterema_df #2168

Open
ezpzbz opened this issue Jun 9, 2021 · 0 comments
Open

[Improvment] duplicated data selection from exterema_df #2168

ezpzbz opened this issue Jun 9, 2021 · 0 comments

Comments

@ezpzbz
Copy link
Contributor

ezpzbz commented Jun 9, 2021

Hi,

I have been using the ChargeInsertionAnalyzer class and realized that within the get_label function, we first select the desired data with average charge density below the maximum threshold from extrema_df:

self._extrema_df = self._extrema_df[self._extrema_df.avg_charge_den <= self.max_avg_charge]

However, later below where we are constructing the inserted_strc, we check again if the site average charge density is below the threshold:

if li_site["avg_charge_den"] > self.max_avg_charge:
continue

I think we remove the latter condition from the loop.

If you think this makes sense to be done, I'd be happy to open a PR.

Cheers,
Pezhman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant