You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been using the ChargeInsertionAnalyzer class and realized that within the get_label function, we first select the desired data with average charge density below the maximum threshold from extrema_df:
Hi,
I have been using the
ChargeInsertionAnalyzer
class and realized that within theget_label
function, we first select the desired data with average charge density below the maximum threshold fromextrema_df
:pymatgen/pymatgen/analysis/defects/utils.py
Line 1344 in c724e7b
However, later below where we are constructing the
inserted_strc
, we check again if the site average charge density is below the threshold:pymatgen/pymatgen/analysis/defects/utils.py
Lines 1347 to 1348 in c724e7b
I think we remove the latter condition from the loop.
If you think this makes sense to be done, I'd be happy to open a PR.
Cheers,
Pezhman
The text was updated successfully, but these errors were encountered: