Fix TaskDoc.task_type #1128
Merged
Fix TaskDoc.task_type #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoteric-ephemera
merged commit 6c3fef0
into
materialsproject:main
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #1127, had wrong branch. Minor bug where TaskDoc.task_type is incorrectly determined for older NSCF line calcs
In TaskDocument, the orig_inputs are used to determine the task_type. The KPOINTS in orig_inputs retain user-input labels, and the NSCF line check currently only looks for these being non-empty
In TaskDoc, the task_type is determined from calcs_reversed.0.input, failing that, input, and failing that, orig_inputs. Both calcs_reversed.0.input and input read KPOINTS from vasprun.xml, which may have labels removed (may have been an issue with older parsed tasks).