Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Badges notes #548

Open
3 tasks done
gselderslaghs opened this issue Dec 11, 2024 · 2 comments
Open
3 tasks done

[Bug]: Badges notes #548

gselderslaghs opened this issue Dec 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@gselderslaghs
Copy link
Member

gselderslaghs commented Dec 11, 2024

Before submitting...

Context

  • Badges should not include textual content in psuedo selector (multilingual transliteration)
    Currently it's possible to add classes to badges like "new", this results in textual content being rendered over CSS
    This makes this feature incompatible with multilingual transliteration

  • Badges do not always adjust in size when textual content increases
    This results textual overflow out of the badge
    Screenshot 2024-12-11 at 14 57 56

Current Behavior

  • Textual content rendered by CSS
  • Textual overflow

Expected behavior

  • All textual content should be rendered in the HTML DOM, as a result it should be renderable in all possible languages
  • Text overflow should not be allowed

Possible Solutions or Causes

Textual content in psuedo
Remove textual content in CSS and update documentation

Textual overflow
Removing the width specifiers and adding a white-space: nowrap; seem to fix this issue
Since badges are used over multiple components, it should be tested in all possible scenario's

Your Environment

  • Version used: 2.1.1
@gselderslaghs gselderslaghs added the bug Something isn't working label Dec 11, 2024
@gselderslaghs gselderslaghs changed the title [Bug]: Badges should not include textual content in psuedo selector (multilingual transliteration) [Bug]: Badges notes Dec 11, 2024
@gselderslaghs
Copy link
Member Author

Looks like it's fixed in v2.2.1 since pr #544, closing for now

@gselderslaghs
Copy link
Member Author

Closed a bit to early, as layout fix seems to be addressed still need to take a look into multilingual transliteration in css pseudo classes
Any ideas? Should we just remove the content: ' new' property from the "new" selector and only allow the data attribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant