Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Modal footer padding not consistent to modal content area #528

Open
3 tasks done
gselderslaghs opened this issue Nov 8, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@gselderslaghs
Copy link
Member

Before submitting...

Context

The Materialize modal footer is not respecting the Material guidelines

Current Behavior

When implementing the Materialize modal, the footer is not respecting the Material guidelines, padding-bottom is hard-coded at 4px while guidelines suggest a padding of 24px
Comparing the Modal component footer section against the Modal component content sections, inner paddings are not appropriate aligned against eachother

Screenshots
Screenshot 2024-11-08 at 13 53 56
Footer padding is not aligned with content padding, right bottom button corner is cut off

Expected behavior

Modal should respect the inner paddings as described by the Material guidelines
Buttons should be fully visible when placed in the footer

Possible Solutions or Causes

Apply modal-padding variable in Modal component footer element styling and remove fixed height

Steps to reproduce

  1. Implement the Modal component
  2. Try out these scenarios
    2.1. Inspect the paddings with browser inspector: paddings not consistent
    2.2. Try out a different button styling as proposed: button corner is cut off

Your Environment

  • Version used: 2.1.1
  • Browser Name and version:
  • Operating System and version (desktop or mobile):
  • Additional information you want to tell us:
@gselderslaghs gselderslaghs added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant