Issue for Popup Definitions

[zhouxq555]

Summary

Popup UI for Definition font style and background style is incorrect

Expected behavior

Modify the config to "theme": "Material-Theme-Palenight.sublime-theme",
The Popup UI is correct

Actual behavior

The default Theme "theme": "Material-Theme.sublime-theme",

Environment

• Operating system and version:
  • Mac OS Sierra 10.12.5
• Sublime Text:
  • Build 3126
• Material Theme release:
  • Latest

[zhouxq555]

no one know?

[buildersbrewery]

As @richardbporter said in the discussion on #882, @equinusocio probably had problems reproducing this functionality of Sublime due to setting "show_definitions": false on his side.

---

For code examples to fix (this popupCss and the phantomCss), see #882 as well.

[equinusocio]

@buildersbrewery thank you.

[equinusocio]

Sublime has popupCss as well as phantomCss now.

You can also use predefined variables as explained in the variables section on https://www.sublimetext.com/docs/3/minihtml.html. Compare below example (using Github's Primer palette of colors):

<key>phantomCss</key><string>
  html {
    background-color: #e1e1e1;
    color: #393939;

    --bg: #e1e1e1;
    --redish: #bd2c00;
    --orangish: #ed6a43;
    --yellowish: #ef9700;
    --greenish: #55a532;
    --cyanish: #0086b3;
    --bluish: #183691;
    --purplish: #a71d5d;
    --brownish: #693a17;
  }

  a {
    color: var(--cyanish);
    text-decoration: underline;
  }

  b, strong {
    font-weight: bold;
  }

  i, em {
    font-style: italic;
  }

  h1 {
    font-size: 2rem;
    border-bottom: 1px solid color(var(--bg) blend(#393939 3%));
  }

  h2 {
    font-size: 1.5rem;
    border-bottom: 1px solid color(var(--bg) blend(#393939 3%));
  }

  h3 {
    font-size: 1.25rem;
  }

  .error, .deleted {
    background-color: color(var(--bg) blend(var(--redish) 50%));
  }

  .success, .inserted {
    background-color: color(var(--bg) blend(var(--greenish) 50%));
  }

  .warning, .modified {
    background-color: color(var(--bg) blend(var(--orangish) 50%));
  }
</string>
<key>popupCss</key><string>
  html {
    background-color: #e1e1e1;
    color: #393939;

    --bg: #e1e1e1;
    --redish: #bd2c00;
    --orangish: #ed6a43;
    --yellowish: #ef9700;
    --greenish: #55a532;
    --cyanish: #0086b3;
    --bluish: #183691;
    --purplish: #a71d5d;
    --brownish: #693a17;
  }

  a {
    color: var(--cyanish);
    text-decoration: underline;
  }

  b, strong {
    font-weight: bold;
  }

  i, em {
    font-style: italic;
  }

  h1 {
    font-size: 2rem;
    border-bottom: 1px solid color(var(--bg) blend(#393939 3%));
  }

  h2 {
    font-size: 1.5rem;
    border-bottom: 1px solid color(var(--bg) blend(#393939 3%));
  }

  h3 {
    font-size: 1.25rem;
  }

  .error, .deleted {
    background-color: color(var(--bg) blend(var(--redish) 50%));
  }

  .success, .inserted {
    background-color: color(var(--bg) blend(var(--greenish) 50%));
  }

  .warning, .modified {
    background-color: color(var(--bg) blend(var(--orangish) 50%));
  }
</string>