Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dependencies #5337

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Conversation

jathak
Copy link
Contributor

@jathak jathak commented Dec 13, 2019

Add missing dependencies to five files that previously didn't depend on all the stylesheets they reference (even indirectly). This caused issues with the module system migrator (#5220), so this fix is necessary for that.

Copy link
Collaborator

@allan-chen allan-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!! Can we rebase onto master so we can sync to internal?

Add missing dependencies to five files that previously didn't depend on
all the stylesheets they reference (even indirectly). This caused issues
with the module system migrator (material-components#5220), so this fix is necessary for
that.
@jathak
Copy link
Contributor Author

jathak commented Dec 19, 2019

Done

@allan-chen allan-chen merged commit d2ae6e1 into material-components:master Dec 19, 2019
@jathak jathak deleted the deps-fix branch December 19, 2019 22:30
abhiomkar pushed a commit that referenced this pull request Dec 20, 2019
Add missing dependencies to five files that previously didn't depend on
all the stylesheets they reference (even indirectly). This caused issues
with the module system migrator (#5220), so this fix is necessary for
that.
This was referenced Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants