-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkbox): change checkbox event type from change to click and add some logic for IE browser #5316
Conversation
…al-components-web into issuefix/4893
update readme and unit test for newly added methods in adapter and foundation pr #5316
Codecov Report
@@ Coverage Diff @@
## master #5316 +/- ##
==========================================
- Coverage 98.52% 98.32% -0.21%
==========================================
Files 163 163
Lines 6309 6322 +13
Branches 864 866 +2
==========================================
Hits 6216 6216
- Misses 93 106 +13
Continue to review full report at Codecov.
|
All 731 screenshot tests passed for commit 35f81b6 vs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
All 728 screenshot tests passed for commit 4a4ace4 vs. |
@bonniezhou @candysonya Hi, is there a CL for this PR? Merging a PR without a CL would create discrepancies for other PRs until we automate this stuff. If CL is not yet submitted please consider reverting this PR. |
Reverting this since it breaks MWC, should sync with internal first. |
Resolve #4893
Run some local test.