Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): change checkbox event type from change to click and add some logic for IE browser #5316

Merged
merged 12 commits into from
Dec 19, 2019

Conversation

candysonya
Copy link
Contributor

@candysonya candysonya commented Dec 9, 2019

Resolve #4893
Run some local test.

@candysonya candysonya requested a review from bonniezhou December 9, 2019 16:38
@candysonya candysonya changed the title Resolve #4893 Bug Fixes Dec 10, 2019
@candysonya candysonya requested a review from jlnjkb December 10, 2019 10:09
@candysonya candysonya changed the title Bug Fixes fix(checkbox): change checkbox event type from change to click and add some logic for IE browser Dec 10, 2019
@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #5316 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5316      +/-   ##
==========================================
- Coverage   98.52%   98.32%   -0.21%     
==========================================
  Files         163      163              
  Lines        6309     6322      +13     
  Branches      864      866       +2     
==========================================
  Hits         6216     6216              
- Misses         93      106      +13
Impacted Files Coverage Δ
packages/mdc-checkbox/foundation.ts 94.33% <100%> (+0.72%) ⬆️
packages/mdc-checkbox/component.ts 96.77% <100%> (+0.03%) ⬆️
packages/mdc-radio/component.ts 87.5% <0%> (-8.34%) ⬇️
packages/mdc-switch/component.ts 91.37% <0%> (-6.9%) ⬇️
packages/mdc-auto-init/index.ts 92% <0%> (-4%) ⬇️
packages/mdc-base/component.ts 93.33% <0%> (-3.34%) ⬇️
packages/mdc-tab/component.ts 95.08% <0%> (-3.28%) ⬇️
packages/mdc-ripple/component.ts 98.11% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95be81...4a4ace4. Read the comment docs.

packages/mdc-checkbox/foundation.ts Outdated Show resolved Hide resolved
packages/mdc-checkbox/foundation.ts Outdated Show resolved Hide resolved
packages/mdc-checkbox/foundation.ts Show resolved Hide resolved
packages/mdc-checkbox/foundation.ts Outdated Show resolved Hide resolved
@bonniezhou bonniezhou self-assigned this Dec 12, 2019
packages/mdc-checkbox/foundation.ts Outdated Show resolved Hide resolved
packages/mdc-checkbox/foundation.ts Outdated Show resolved Hide resolved
test/unit/mdc-checkbox/foundation.test.js Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 35f81b6 vs. master! 💯🎉

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdc-web-bot
Copy link
Collaborator

All 728 screenshot tests passed for commit 4a4ace4 vs. master! 💯🎉

@candysonya candysonya merged commit 2e491de into master Dec 19, 2019
@candysonya candysonya deleted the issuefix/4893 branch December 19, 2019 10:45
@abhiomkar
Copy link
Collaborator

@bonniezhou @candysonya Hi, is there a CL for this PR? Merging a PR without a CL would create discrepancies for other PRs until we automate this stuff.

If CL is not yet submitted please consider reverting this PR.

@allan-chen
Copy link
Collaborator

Reverting this since it breaks MWC, should sync with internal first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkbox] Checkbox does not trigger change event when on indeterminate
7 participants