refactor(checkbox): Add Jasmine test for checkbox foundation. #5299

joyzhong · 2019-12-03T18:49:31Z

Add checkbox foundation test using Jasmine framework (converted from existing Mocha test). Does not delete Mocha test yet; this will be done in a follow-up PR.
Set up Karma config such that npm run test:jasmineunit runs Karma/Jasmine unit tests, npm run test:mochaunit runs Karma/Mocha unit tests, and npm run test:unit runs both.
Set up code coverage via karma-typescript/istanbul. Thresholds are lowered for now since Jasmine tests do not cover component tests, which were increasing the coverage percentage.

codecov-io · 2019-12-03T19:00:57Z

Codecov Report

Merging #5299 into master will decrease coverage by 0.32%.
The diff coverage is 88.23%.

@@            Coverage Diff            @@
##           master   #5299      +/-   ##
=========================================
- Coverage   98.63%   98.3%   -0.33%     
=========================================
  Files         122     162      +40     
  Lines        6000    6311     +311     
  Branches      772     866      +94     
=========================================
+ Hits         5918    6204     +286     
- Misses         81     106      +25     
  Partials        1       1

Impacted Files	Coverage Δ
testing/helpers/setup.ts	`100% <100%> (ø)`
testing/helpers/foundation.ts	`87.23% <87.23%> (ø)`
packages/mdc-dom/events.ts	`90.9% <0%> (-9.1%)`	⬇️
packages/mdc-ripple/util.ts	`82.35% <0%> (-7.65%)`	⬇️
packages/mdc-auto-init/index.ts	`92% <0%> (-3.84%)`	⬇️
packages/mdc-base/component.ts	`93.33% <0%> (-3.1%)`	⬇️
packages/mdc-top-app-bar/component.ts	`98.5% <0%> (-1.5%)`	⬇️
packages/mdc-drawer/component.ts	`98.7% <0%> (-1.3%)`	⬇️
packages/mdc-chips/chip-set/component.ts	`97.4% <0%> (-1.29%)`	⬇️
packages/mdc-tab-bar/foundation.ts	`98.89% <0%> (-1.11%)`	⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7b71a...ef328ba. Read the comment docs.

mdc-web-bot · 2019-12-03T19:06:17Z

All 731 screenshot tests passed for commit 89fd463 vs. master! 💯🎉

mdc-web-bot · 2019-12-03T20:58:15Z

All 731 screenshot tests passed for commit e8fe73d vs. master! 💯🎉

mdc-web-bot · 2019-12-03T22:22:05Z

All 731 screenshot tests passed for commit 37977e3 vs. master! 💯🎉

mdc-web-bot · 2019-12-03T23:04:47Z

All 731 screenshot tests passed for commit f1accc0 vs. master! 💯🎉

mdc-web-bot · 2019-12-04T15:43:26Z

All 731 screenshot tests passed for commit 4997bd0 vs. master! 💯🎉

abhiomkar

LGTM!

karma.conf.js

packages/mdc-checkbox/.npmignore

testing/helpers/foundation.ts

packages/mdc-checkbox/test/foundation.test.ts

mdc-web-bot · 2019-12-04T17:00:48Z

All 731 screenshot tests passed for commit 18e505a vs. master! 💯🎉

mdc-web-bot · 2019-12-04T17:02:46Z

All 731 screenshot tests passed for commit 43b81f4 vs. master! 💯🎉

mdc-web-bot · 2019-12-04T17:23:15Z

All 731 screenshot tests passed for commit e67d884 vs. master! 💯🎉

mdc-web-bot · 2019-12-04T17:43:55Z

All 731 screenshot tests passed for commit 032a1ba vs. master! 💯🎉

mdc-web-bot · 2019-12-04T21:39:50Z

All 731 screenshot tests passed for commit feb7d1d vs. master! 💯🎉

mdc-web-bot · 2019-12-04T22:04:26Z

All 731 screenshot tests passed for commit 6c08dca vs. master! 💯🎉

mdc-web-bot · 2019-12-05T16:36:58Z

All 731 screenshot tests passed for commit 6929207 vs. master! 💯🎉

mdc-web-bot · 2019-12-05T17:01:49Z

All 731 screenshot tests passed for commit 406d532 vs. master! 💯🎉

mdc-web-bot · 2019-12-06T19:52:56Z

All 731 screenshot tests passed for commit 7d2631d vs. master! 💯🎉

mdc-web-bot · 2019-12-09T16:36:42Z

All 731 screenshot tests passed for commit ef328ba vs. master! 💯🎉

…shot tests from running.

joyzhong added 3 commits November 26, 2019 14:27

Add initial test.

aae4d61

Set up jasmine/karma config.

86664fa

Set up jasmine test config

89fd463

googlebot added the cla: yes label Dec 3, 2019

Exclude new test files from linter and npm packaging.

e8fe73d

joyzhong added 2 commits December 3, 2019 16:51

Move test helpers to testing/helpers/

8c299fc

Add testing/helpers

37977e3

Include Jasmine test run in npm run test:unit.

f1accc0

Fix IE 11 test

4997bd0

Clean up karma config

18e505a

abhiomkar approved these changes Dec 4, 2019

View reviewed changes

karma.conf.js Show resolved Hide resolved

packages/mdc-checkbox/.npmignore Show resolved Hide resolved

testing/helpers/foundation.ts Outdated Show resolved Hide resolved

packages/mdc-checkbox/test/foundation.test.ts Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/master' into refactor/checkbox_test

43b81f4

Edits

e67d884

Move coverage reporter to combined config

032a1ba

Add code coverage

feb7d1d

Merge remote-tracking branch 'origin/master' into refactor/checkbox_test

6c08dca

Fix typos

6929207

Fix regex to not test screenshots for test/ changes

406d532

Merge remote-tracking branch 'origin/master' into refactor/checkbox_test

7d2631d

erge remote-tracking branch 'origin/master' into refactor/checkbox_test

ef328ba

joyzhong merged commit a0da497 into master Dec 9, 2019

joyzhong deleted the refactor/checkbox_test branch December 9, 2019 17:37

joyzhong added a commit that referenced this pull request Dec 11, 2019

Revert change from #5299 as this is suspected to be preventing screen…

0c7c6d8

…shot tests from running.

joyzhong added a commit that referenced this pull request Dec 11, 2019

fix(testing): Revert change from #5299. (#5324)

5fb62be

This was referenced Feb 13, 2020

chore: Release #5609

Merged

chore: Release #5610

Closed

snyk-bot mentioned this pull request Mar 7, 2020

[Snyk] Upgrade material-components-web from 5.0.0 to 5.1.0 philwareham/textpattern-material-components-web#179

Open

adrianschmidt mentioned this pull request Dec 10, 2020

Update to the latest version of MDC Lundalogik/lime-elements#1070

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(checkbox): Add Jasmine test for checkbox foundation. #5299

refactor(checkbox): Add Jasmine test for checkbox foundation. #5299

joyzhong commented Dec 3, 2019 •

edited

Loading

codecov-io commented Dec 3, 2019 •

edited

Loading

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 4, 2019

abhiomkar left a comment

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 5, 2019

mdc-web-bot commented Dec 5, 2019

mdc-web-bot commented Dec 6, 2019

mdc-web-bot commented Dec 9, 2019

refactor(checkbox): Add Jasmine test for checkbox foundation. #5299

refactor(checkbox): Add Jasmine test for checkbox foundation. #5299

Conversation

joyzhong commented Dec 3, 2019 • edited Loading

codecov-io commented Dec 3, 2019 • edited Loading

Codecov Report

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 3, 2019

mdc-web-bot commented Dec 4, 2019

abhiomkar left a comment

Choose a reason for hiding this comment

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 4, 2019

mdc-web-bot commented Dec 5, 2019

mdc-web-bot commented Dec 5, 2019

mdc-web-bot commented Dec 6, 2019

mdc-web-bot commented Dec 9, 2019

joyzhong commented Dec 3, 2019 •

edited

Loading

codecov-io commented Dec 3, 2019 •

edited

Loading