Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

[Button] Outlined outline color should not be set to primary but 12% on-surface #5170

Closed
e111077 opened this issue Oct 12, 2019 · 3 comments · Fixed by #5268
Closed

[Button] Outlined outline color should not be set to primary but 12% on-surface #5170

e111077 opened this issue Oct 12, 2019 · 3 comments · Fixed by #5268
Labels

Comments

@e111077
Copy link

e111077 commented Oct 12, 2019

Bug report

The Material spec for button theming Material spec notes that the border color of an outlined button should be set to secondary theme on-surface at 12%, but we seem to set it as primary

Steps to reproduce

  1. Create an mdc-button that is outlined
  2. Set secondary to be a different color, like red

Actual behavior

The outline of the button is the same, primary color

Expected behavior

The outline of the button should be the secondary color (red in this case)

Screenshots

Your Environment:

Software Version(s)
MDC Web canary
Browser chrome
Operating System macos

Additional context

Possible solution

@e111077 e111077 added the bug label Oct 12, 2019
@abhiomkar
Copy link
Collaborator

For records, it seems like the spec says On Surface, 12%. But not secondary.

image

@e111077
Copy link
Author

e111077 commented Oct 14, 2019

Heya, perhaps it's a typo in the theming section in the buttons part in material.io:

image

@e111077
Copy link
Author

e111077 commented Oct 14, 2019

update: internal chat pointed out that the doc I pointed to is not spec, but also that it should still not be primary but on-surface 12%

@allan-chen allan-chen changed the title [Button] Outlined outline color should not be set to primary but secondary [Button] Outlined outline color should not be set to primary but 12% on-surface Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants