Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow <mwc-snackbar> open method to be called before firstUpdated #356

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

aomarks
Copy link
Contributor

@aomarks aomarks commented Aug 9, 2019

This bit me in testing, and turns out at least one other user has already encountered it. I can imagine wanting to create the element and immediately open it might be a common enough pattern that we should support this.

Fixes #308

@aomarks aomarks requested a review from dfreedm August 9, 2019 16:51
Copy link
Collaborator

@dfreedm dfreedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfreedm dfreedm merged commit b42cac9 into master Aug 9, 2019
@dfreedm dfreedm deleted the snackbar-early-open branch August 9, 2019 21:54
@aomarks aomarks changed the title Allow <mwc-button> open method to be called before firstUpdated Allow <mwc-snackbar> open method to be called before firstUpdated Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdcFoundation should be initialised before firstUpdated
4 participants