Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomSheetBehavior] Shape corners behavior question and possible bug #614

Closed
Zeliret opened this issue Sep 21, 2019 · 5 comments
Closed

Comments

@Zeliret
Copy link

Zeliret commented Sep 21, 2019

If a bottom sheet has rounded courners it will animate its to sharp state if the sheet is fully expanded.
But I believe it should keep rounded corners if it height is smaller than the screen height and fit contents is true.
So we can see a nice rounded bottom sheet with a small menu for example.

@Zeliret Zeliret added the bug label Sep 21, 2019
@hrach
Copy link
Contributor

hrach commented Sep 21, 2019

#437

@Zeliret
Copy link
Author

Zeliret commented Sep 21, 2019

@hrach When it will be merged?

@hrach
Copy link
Contributor

hrach commented Sep 21, 2019

No idea. Just linking pr. :-)

@Zeliret
Copy link
Author

Zeliret commented Sep 21, 2019

I have found a nice method BottomSheetBehavior::disableShapeAnimations() which is marked as LIBRARY_GROUP. It can do the trick as well but we need to get it as public.

@ldjcmu
Copy link
Contributor

ldjcmu commented Sep 24, 2019

Marking this as a dup of #463. I'll check-in on the PR status.

@ldjcmu ldjcmu closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants