rid of deprecated mongodb methods #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 2 2
Lines 237 237
Branches 49 50 +1
=======================================
Hits 232 232
Misses 5 5
Continue to review full report at Codecov.
|
|
Hi @debianw. Thanks for this PR, and apologies for missing it. Any chance you can rebase against master and push? We'll get this merged in. |
patrickleet
pushed a commit
that referenced
this pull request
May 26, 2020
patrickleet
added a commit
that referenced
this pull request
May 26, 2020
BREAKING CHANGE: Now defaults to new mongo db client options `useNewUrlParser` and `useUnifiedTopology`. Travis changed to test last two Node versions, 12 and 14. * feat: mongodb replica set support * chore: add 10 to tests * fix: lock to sourced 2.0.5 * fix: sourced bug - upgrade to fixed 2.0.7 * fix: [email protected] * chore: update travis file * chore: rm debug log statements * chore: rm debug log statements * fix: make options configurable * fix: cherry pick changes from @debianw - PR #35 Co-authored-by: Waly <[email protected]>
|
cherry picked and included in #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New mongodb client (3.1.10) which is in
package-lock.jsonis throwing warnings like:DeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes insteadDeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes instead.DeprecationWarning: collection.insert is deprecated. Use insertOne, insertMany or bulkWrite insteadThis PR will fix those by using the new methods.