Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not working properly #183

Closed
ebrondol opened this issue Oct 19, 2018 · 6 comments
Closed

Icons not working properly #183

ebrondol opened this issue Oct 19, 2018 · 6 comments
Labels

Comments

@ebrondol
Copy link

Hi, I have recently update the website with the fix of the search function (PR #177) and now it works! Thanks! But another issue come up: the icons are either not visible anymore or replaced by squares.
Is someone else experiencing the same issue? Is maybe already a work going on to fix it?

@matalo33
Copy link
Contributor

Could you explain the symptoms a little? Are you getting 404 errors for the icons? Is your site on github for us to see? Can you see the theme malforming the urls to icons? Thanks

@ebrondol
Copy link
Author

Sure, this is the screenshot of my website after I update the theme:
screenshot from 2018-10-20 13-01-57
As you can see some icons on the left are visible (like GitHub, camera, books, etc), while the arrow and the search icons are replaced by a square. I am using Google Chrome Version 69.0.3497.81 (Official Build) (64-bit), but I have a very similar effect with Firefox.

@matalo33
Copy link
Contributor

Sorry I can't reproduce this. Is your repository public?

@ebrondol
Copy link
Author

Hi, yes, the repository is public, you can find it here:
https://gitlab.cern.ch/CLICdp/HGCAL/HGCAL_sensor_web/
Thank you very much!

@jice-lavocat
Copy link
Contributor

Hi @ebrondol ,
They've updated font-awesome library link in the header.html file.

In your code, you have a custom one, change this line : https://gitlab.cern.ch/CLICdp/HGCAL/HGCAL_sensor_web/blob/master/layouts/partials/header.html#L13

for this: <link href="{{"css/fontawesome-all.min.css" | relURL}}{{ if $assetBusting }}?{{ now.Unix }}{{ end }}" rel="stylesheet">

@ebrondol
Copy link
Author

Thank you @tanzaho, the fix is working! I should be more careful with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants