Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit IPv6 egress #21

Closed
mheffner opened this issue May 8, 2024 · 7 comments · Fixed by #22
Closed

Permit IPv6 egress #21

mheffner opened this issue May 8, 2024 · 7 comments · Fixed by #22

Comments

@mheffner
Copy link
Contributor

mheffner commented May 8, 2024

The security group permits IPv4 egress, but does not permit IPv6. It would be great to support both!

@Gowiem
Copy link
Member

Gowiem commented May 8, 2024

@mheffner 100% and should be an easy thing to do. Feel free to submit a PR and we'll get it in ASAP or we'll leave this open and someone from my team will take a crack at it soon. We have a new engineer starting this week, so I may have him knock this out since it's simple and a good intro to the open source work we do internally.

@mheffner
Copy link
Contributor Author

mheffner commented May 9, 2024

Thanks @Gowiem ! For now we've attached a second SG to the instances (we're using the tailscale module), so we're not in a big rush. No rush from our side, but I wanted to note the gap. Sounds like a great first ticket!

@Gowiem
Copy link
Member

Gowiem commented May 15, 2024

@mheffner my colleague @oycyc completed this work and it has been released as 1.1.0. Let us know how it works for you!

@mheffner
Copy link
Contributor Author

Thanks @Gowiem and @oycyc , any chance you can bump the dep in https://github.com/masterpointio/terraform-aws-tailscale?

@oycyc
Copy link
Contributor

oycyc commented May 16, 2024

Thanks @Gowiem and @oycyc , any chance you can bump the dep in https://github.com/masterpointio/terraform-aws-tailscale?

Great point, thanks for that!

@Gowiem
Copy link
Member

Gowiem commented May 16, 2024

@mheffner updated downstream in https://github.com/masterpointio/terraform-aws-tailscale/releases/tag/1.1.0 👍 Thanks for the push!

@mheffner
Copy link
Contributor Author

Thanks @oycyc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants