Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network handling #1134

Open
thomas-senechal opened this issue Aug 30, 2023 · 3 comments
Open

Improve network handling #1134

thomas-senechal opened this issue Aug 30, 2023 · 3 comments

Comments

@thomas-senechal
Copy link
Member

Context
For now, we can only switch between 3 networks. Those networks are listed in config_network.yaml and embedded in the Station binary.
The front end displays the list of networks available in the yaml file, but the endpoint to change network (POST /network/{network}) only accepts testnet, buildnet and labnet, so if we add a network to the yaml file, it's not possible to change the used network to this network.

A solution to this issue is to remove the enum of the POST /network/{network} endpoint so we can use any network from the yaml file.

User flow
Describe the user flow using user stories so the end result is super clear - PM

How to

Technical details
Give the technical insights so anyone in the team can tackle the tasks - Dev

QA testing
Does this task require some QA tests ?
If yes, explain how to validate it

@thomas-senechal
Copy link
Member Author

Need to be discussed

We could also add the possibility for the users to create config file in the config directory that would add some available networks. That would allow them to add a local (or distant) node and allow us to use custom nodes or DNS for development.

@B-Naoufal
Copy link
Contributor

yes, We can an endpoint just for that!

@Thykof
Copy link
Contributor

Thykof commented Jan 9, 2024

related to #1317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants