Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibrate and adjust APIs arguments limits #4475

Closed
aoudiamoncef opened this issue Oct 13, 2023 · 2 comments · Fixed by #4536
Closed

Calibrate and adjust APIs arguments limits #4475

aoudiamoncef opened this issue Oct 13, 2023 · 2 comments · Fixed by #4536
Assignees
@aoudiamoncef
Labels
api Issues related to the API enhancement New feature or request need spec This issue need more specification

Comments

@aoudiamoncef
Copy link
Contributor

aoudiamoncef commented Oct 13, 2023 •
edited
Loading

Currently, we have set a lot of limitations which aren't accurate sometimes. We have to update this to ensure the security and improve the usability of the APIs(JsonRPC/gRPC)

See node configuration
See client configuration
@aoudiamoncef aoudiamoncef added enhancement New feature or request api Issues related to the API need spec This issue need more specification labels Oct 13, 2023
This was referenced Oct 20, 2023
Closed
Open
@aoudiamoncef
Copy link
Contributor Author

In general, the limits should be similar to network protocol but we have to pay attention to some values in the API

@Leo-Besancon
Copy link
Collaborator

Yes this is an important issue, we need to clarify what limits have been calibrated and how to calibrate the rest!
@modship and @aoudiamoncef, can you sync on this and document what is done and what is to be done?

@Leo-Besancon Leo-Besancon linked a pull request Nov 23, 2023 that will close this issue
Adjust node APIs settings #4536
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aoudiamoncef aoudiamoncef

Labels
api Issues related to the API enhancement New feature or request need spec This issue need more specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust node APIs settings massalabs/massa
2 participants
@aoudiamoncef @Leo-Besancon