remove risky/heavy unused dependencies

[aoudiamoncef]

Candidates to removal:

• paw is not referenced in the codebase.
• quiche is not a direct massa dependency but It's deeply integrated in PeerNet . CC @AurelienFT
• rayon is used once in the codebase in:

pub fn verify_sigs_batch(ops: &[(Hash, Signature, PublicKey)]) -> Result<(), ProtocolError> {
    // if it's a small batch, use single-core verification
    if ops.len() <= SMALL_BATCH_LIMIT {
        return verify_signature_batch(ops).map_err(|_err| ProtocolError::WrongSignature);
    }

    // otherwise, use parallel batch verif

    // compute chunk size for parallelization
    let chunk_size = std::cmp::max(1, ops.len() / rayon::current_num_threads());
    // process chunks in parallel
    ops.par_chunks(chunk_size)
        .try_for_each(verify_signature_batch)
        .map_err(|_err| ProtocolError::WrongSignature)
}

• paginate crate could be removed as we can remove pagination in get_stakers in JsonRPC API.
• All dependencies should be forked officially (with massa namespace) to avoid bad surprises:

unsigned-varint = { version = "=0.7", "git" = "https://github.com/cyphar/unsigned-varint.git", "branch" = "nom6-errors" }
substruct = { git = "https://github.com/sydhds/substruct", branch = "main" }
machine = { git = "https://github.com/antifuchs/machine", "branch" = "fix-workspace-build" }

[aoudiamoncef]

We can go beyond by disabling the default features in dependencies crate and choose only what we need.

See the complete output dep_tree_features.txt

[aoudiamoncef]

cc @Leo-Besancon

[Leo-Besancon]

Candidates to removal:

* `paw` is not referenced in the codebase.

We should indead remove it

* `quiche` is not a direct massa dependency but It's deeply integrated in `PeerNet` . CC @AurelienFT

I think we should clean it on the massa repo then, I don't see why not. (If we do need it in the future we just have to make sure we align the versions).

* `rayon` is used once in the codebase in:

Can you compare the alternatives? I see https://docs.rs/num_threads/latest/num_threads/index.html that could be lighter to depend on if it's the same behaviour.

* `paginate` crate could be removed as we can remove pagination in `get_stakers` in JsonRPC API.

If there are no bad consequences of this, go for it. But if we aim to support JsonRPC for a bit longer we should not "downgrade" it IMO.

* All  dependencies should be forked officially (with massa namespace) to avoid bad surprises:

unsigned-varint = { version = "=0.7", "git" = "https://github.com/cyphar/unsigned-varint.git", "branch" = "nom6-errors" }
substruct = { git = "https://github.com/sydhds/substruct", branch = "main" }
machine = { git = "https://github.com/antifuchs/machine", "branch" = "fix-workspace-build" }

Maybe it's not necessary for all of them, the .lock should prevent most trouble, no? Or maybe it's easier to just target a fixed rev, not sure.

[aoudiamoncef]

@Leo-Besancon we can't remove rayonas it's used not only to get the number of threads but also to do the calculation.

[Leo-Besancon]

@Leo-Besancon we can'"t remove rayonas it's used not only to get the number of threads but also to do the calculation.

Indeed I misread the code!

[aoudiamoncef]

We have a last point to see with @sydhds about forking the 3 repositories above

[sydhds]

We have a last point to see with @sydhds about forking the 3 repositories above

• substruct is a crate I've written and it can be forked in Massa orga (would be nice to keep on contributing it upstream :))
• machine can be forked in Massa orga too (used by Versioning)
• unsigned-varint could use the (not verified) more up to date lib here: https://github.com/paritytech/unsigned-varint

[Leo-Besancon]

We have a last point to see with @sydhds about forking the 3 repositories above

* substruct is a crate I've written and it can be forked in Massa orga (would be nice to keep on contributing it upstream :))

https://github.com/massalabs/substruct

* machine can be forked in Massa orga too (used by Versioning)

https://github.com/massalabs/machine/tree/fix-workspace-build

(I'll let you @aoudiamoncef merge to main if you think it's relevant to do so)

* unsigned-varint could use the (not verified) more up to date lib here: https://github.com/paritytech/unsigned-varint

@aoudiamoncef can you try and update to this one? Check if there is a release on crates, etc. We'll fork it if needed