use system rustup to get rustfmt #2055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
reviewed
Jul 4, 2023
There was a problem hiding this comment.
I opened an issue with them regarding this recently, and it seems unlikely that the release binaries they provide will be functional going forward. As mentioned in #2054, I think the appropriate action would be to deprecate rustfmt in Mason and inform users to install and manage it externally via rustup component. This is also the guidance from rustfmt maintainers, and is the only officially supported installation method.
Comment on lines
+14
to
+17
| id: pkg:generic/rustfmt@x | ||
| build: | ||
| run: cp $(which rustfmt) . || echo "rustfmt not found" | ||
| bin: rustfmt |
There was a problem hiding this comment.
This is problematic for a couple of reasons:
- It has a placeholder version number. Packages must refer to real version numbers.
- The build script simply copies an external installation of
rustfmtinto the Mason installation directory. This is not a self-contained installation, and may also be problematic for loading linked libraries (relativerpath). This is likely also problematic because it will use whatever toolchain is currently active. - Doesn't support Windows (although this would be an easy fix by providing a powershell script as well).
|
Superseded by #2059 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first stab at creating a new package.yaml for rustfmt as the current one is broken (see #2054).
I could not figure out how I can test this.
Please comment on how it could be improved.