-
Notifications
You must be signed in to change notification settings - Fork 123
Update node version to 16 #2
base: master
Are you sure you want to change the base?
Conversation
As node 12 has been deprecated and Github is looking to upgrade all github actions to node 16 (more https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ ) this commit will update the node version used.
I think this PR covers more warnings: marvinpinto/actions#546 |
https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
Is there any fork we can use until it merged? |
Till such PRs are merged, I am using the commit hashes of the PRs. For this PR, to resolve Node 12 warning, I could use:
|
…version is updated (so it won't get deprecated soon) In line with suggestion by rtrad89 in marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
cc @marvinpinto 🙏🏻 |
@marvinpinto Please merge |
Is there an alternative repo that we can use? |
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
CI: try to fix missing packages ci: drop 32-bit r64 (default is now 64bit) ci: drop python-mako ci: update checkout and cache to v3 https://github.com/actions/cache for additional warnings a PR is open for marvinpinto/automatic-releases marvinpinto/action-automatic-releases#2
@gurza do you have any advice on a config that can replicate how this works with https://github.com/softprops/action-gh-release |
Here is an example of a workflow using action-gh-release. The workflow is triggered whenever a new tag is pushed to your repository. name: Release
on:
push:
tags:
- '*'
jobs:
release:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Build project
run: |
# insert your project's build command here
- name: Create GitHub Release
uses: softprops/action-gh-release@v1
with:
files: |
path/to/file1
path/to/file2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} The GITHUB_TOKEN secret is a GitHub App installation access token and is used to authenticate in order to create the release. |
Dude, I've forked this due to this NOT being merged. You need to get this fix into the repository. |
Hey, on my side I switched to |
The update to node 16 has been un-merged for a long time: marvinpinto/action-automatic-releases#2
It doesn't really work the same for me, have to bump a version tag with the one you linked, unless I'm missing something |
Do you have anything to link ? And for everyone, this will be outdated soon as Github is switching to node 20 soon : https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ |
@marvinpinto has not pushed any commits into GH at all (i.e. any activity in any repo) since April, 2023; I'd consider this project abandoned at this point. |
So I spent a couple days trying to find a suitable alternative that can replace this action. My criteria was getting a similar changelog because the other options don't exactly do the same. I've finally settled on something so might as well share so you don't have to waste time. I ended up using https://github.com/tj-actions/git-cliff to generate the changelog and then https://github.com/ncipollo/release-action to upload the release with the changelog and artifacts. Both of these projects are actively maintained at the time of writing this. name: Release
on:
push:
tags:
- 'v*.*.*'
jobs:
release:
name: Release
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 0 # Important for changelog
- name: Generate changelog with git-cliff
uses: tj-actions/git-cliff@v1
with:
args: --latest --strip all
output: "CHANGELOG.md"
- name: Create Release
uses: ncipollo/release-action@v1
with:
artifacts: "dist/*"
token: ${{ secrets.GITHUB_TOKEN }}
bodyFile: "CHANGELOG.md"
draft: false
prerelease: false
|
Abandoning this action, I did a direct replacement using |
There's some options for replacement listed at marvinpinto/action-automatic-releases#2 .. just better to do that lift & shift separately from this chain.
* Fix deb release flow to find the artefacts In a matrix build they end up separated by directories. This fix sidesteps the whole problem and downloads them into a single directory with a pattern. * Temporarily disable repo check to fully test previous commit * Try without a filter, since it didn't match for some reason * Add a TODO for marvinpinto/action-automatic-releases replacement There's some options for replacement listed at marvinpinto/action-automatic-releases#2 .. just better to do that lift & shift separately from this chain. * Revert "Temporarily disable repo check to fully test previous commit" This reverts commit 9f2f088. --------- Co-authored-by: Jinna Kiisuo <[email protected]>
I found that this setup just appends the artifacts to an existing release instead of creating a new one, were you able to fix that? |
This action has been forked and updated in a backwards-compatible way at https://github.com/crowbarmaster/GH-Automatic-Releases Actions marketplace URL: https://github.com/marketplace/actions/cbgh-automatic-releases |
Seems to create new releases for me? |
That would be because you are pushing to a new tag each time, in my case I just push to 'latest' tag |
I see, I'm not familiar with that use in GH releases, it is not like a docker tag. If you use an actual versioned tag for release and prerelese then the github API can give you the latest released and latest prerelease version. |
Yes but not everyone uses semver, my point was simply that the softprops alternative behaved differently as a drop-in replacement for our use case |
This one however is working a charm 👌 |
Will keep it in mind as backup, thx. |
As node 12 has been deprecated and Github is looking to upgrade all github actions to node 16 (more https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ ) this commit will update the node version used.