Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial merge and empty sink level #471

Open
martinsumner opened this issue Jan 20, 2025 · 0 comments
Open

Partial merge and empty sink level #471

martinsumner opened this issue Jan 20, 2025 · 0 comments

Comments

@martinsumner
Copy link
Owner

The addition of partial merge doesn't handle a merge that creates and empty result.

For example, if a set of files containing nothing but leveled tombstones are handled in the partial merge:

{KL2Additions, [], []} = add_entry(NewMergeKL2, FNSnk, TS2, Additions),

This might return {empty, [], Additions} not {KL2Additions, [], []}. This will cause the clerk to crash, and this should ripple up to the store crashing.

riak_SUITE:test_large_lsm_merge/1 may detect this rarely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant