You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a small inconsistency to the other projects - because also typescript version has it.
There is a main entry point (class, whatever) which calls createApp and then gets the connection and the application. It will print a message with a test URL and proper port (look into index.ts in the Typescript) and then starts the app by listening. So please instead of having the run of app in the main method of Prices, please create a separate file.
The createApp is also returning the connection, so tests can close it after running. I do not see the tests closing the connection, maybe a method provided to shutdown of process? I think it's OK to get the values app and importing by running the module like it is now, connection is just available globally then?
There is a small inconsistency to the other projects - because also typescript version has it.
There is a
main
entry point (class, whatever) which callscreateApp
and then gets the connection and the application. It will print a message with a test URL and proper port (look intoindex.ts
in the Typescript) and then starts the app by listening. So please instead of having the run of app in the main method ofPrices
, please create a separate file.The
createApp
is also returning the connection, so tests can close it after running. I do not see the tests closing the connection, maybe a method provided to shutdown of process? I think it's OK to get the valuesapp
and importing by running the module like it is now, connection is just available globally then?Originally posted by @codecop in #61 (comment)
The text was updated successfully, but these errors were encountered: