Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight inconsistency in the python version #63

Open
martinsson opened this issue Mar 12, 2023 · 0 comments
Open

Slight inconsistency in the python version #63

martinsson opened this issue Mar 12, 2023 · 0 comments

Comments

@martinsson
Copy link
Owner

There is a small inconsistency to the other projects - because also typescript version has it.

  1. There is a main entry point (class, whatever) which calls createApp and then gets the connection and the application. It will print a message with a test URL and proper port (look into index.ts in the Typescript) and then starts the app by listening. So please instead of having the run of app in the main method of Prices, please create a separate file.

  2. The createApp is also returning the connection, so tests can close it after running. I do not see the tests closing the connection, maybe a method provided to shutdown of process? I think it's OK to get the values app and importing by running the module like it is now, connection is just available globally then?

Originally posted by @codecop in #61 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant