Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doplnit testy pre nove features #281

Open
martinmacko47 opened this issue May 15, 2020 · 1 comment
Open

Doplnit testy pre nove features #281

martinmacko47 opened this issue May 15, 2020 · 1 comment

Comments

@martinmacko47
Copy link
Owner

martinmacko47 commented May 15, 2020

Depends on #280

Prejdi si vsetky svoje PR, co si doteraz spravil, a ku kazdemu PR sa zamysli, ci netreba doplnit nejake testy. Ak ano, dopln ich.

Testy by mali byt napisane tak, aby presli vsetkymi vetvami kodu. Tj. vo vseobecnosti ak je niekde if X, tak by mal existovat test, kde X bolo true, aj test, kde X bolo false. Testy by mali pokryvat pozitivne pripady aj negativne pripady. Tj. ze sa da, co sa ma dat, a ze sa neda, co sa nema dat. Testy by mali overovat hlavne extremne pripady. Napriklad ak sa nieco da od 0 do 100 a neda od 101, tak by mali byt testy pre -1, 0, 100 a 101.

Okrem toho by testy mali overovat funkcnost pouzitych libiek resp. inych externych nastrojov. Hlavne ak sa niekde v kode spoliehas sa nieco, co nie je uplne presne zdokumentovane v dokumentacii danej libky/toolu. Aby ked danu libku/tool upgradneme, a nastala v nej nekompatibilna zmena, aby sme si to na zaklade padajuceho testu vsimli.

Ku kazdemu PR, co si doteraz spravil, sprav novy PR s testami pren. Do popisu PR s testami daj linku na povodny PR, ku ktoremu testy patria.

Napriklad vid: #283 (comment)

@martinmacko47 martinmacko47 added this to the 2020 milestone May 15, 2020
@martinmacko47 martinmacko47 changed the title Testy: Doplnit testy pre nove features Doplnit testy pre nove features Nov 4, 2020
@martinmacko47
Copy link
Owner Author

*label blocked rusim, stav issue nahradza stlpec v boarde

@martinmacko47 martinmacko47 removed this from the 2020 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants