Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for conflicting entries #9

Open
martinheidegger opened this issue Apr 19, 2021 · 0 comments
Open

Add warning for conflicting entries #9

martinheidegger opened this issue Apr 19, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@martinheidegger
Copy link
Owner

Conflicting entries are currently deterministically resolved using the "highest relevant" node:

https://github.com/martinheidegger/hyper-dns/blob/main/resolve-context.js#L84-L88

however, as this may be unexpected behavior it may be better to add a warning to the output (like CORS configuration) and even with debugging disabled it may be a good idea throw an error message in that case.

@martinheidegger martinheidegger added enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant