Comments about vignette

[HeidiSeibold]

@mmostly-harmless you asked me to take a look at the vignette. Here are my comments. None of these are crucial. So don't feel obliged to incorporate them. All in all I like the vignette 🎆 .

• I am wondering if it would be easier to start with a ctree()-example rather than one where you create the tree yourself.

https://github.com/mmostly-harmless/ggparty/blob/83539bd0a98b2a5f8c20b1feffae935945e34a0a/vignettes/ggparty-graphic-partying.Rmd#L138-L150

• One of the comments below shows after the plot. Could be nicer. Maybe write it in text rather than in comment?

https://github.com/mmostly-harmless/ggparty/blob/83539bd0a98b2a5f8c20b1feffae935945e34a0a/vignettes/ggparty-graphic-partying.Rmd#L208-L214

• Section Additional Data does seem quite advanced for this early in the vignette. I would first show a couple of simple examples. Maybe even have a separate vignette for this?

• When are predictions possible?

https://github.com/mmostly-harmless/ggparty/blob/83539bd0a98b2a5f8c20b1feffae935945e34a0a/vignettes/ggparty-graphic-partying.Rmd#L437-L439

• Maybe show the Autoplot Methods earlier in the vignette?