Fix up plugin descriptor dependencies #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move of a the composite aggs code to the aggregations plugin, this effectively renders the aggregation plugin as an Extensible plugin ( since x-pack-core uses the composite aggs code directly ). The X-pack-core plugin then requires to "extend" the aggregation plugin, so that the classloader hierarchy is setup correctly at runtime. Following all this, lang-painless is now transitively required (by the aggregations plugin ), for all plugins extending x-pack-core, so we need to move it as an explicit "extends" from plugins that extend from x-pack-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move of a the composite aggs code to the aggregations plugin, this effectively renders the aggregation plugin as an Extensible plugin ( since x-pack-core uses the composite aggs code directly ). The X-pack-core plugin then requires to "extend" the aggregation plugin, so that the classloader hierarchy is setup correctly at runtime. Following all this, lang-painless is now transitively required (by the aggregations plugin ), for all plugins extending x-pack-core, so we need to move it as an explicit "extends" from plugins that extend from x-pack-core