Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KeyDown instead of KeyUp to handle MainView keyboard shortcuts #3354

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

tkohlmeier
Copy link
Contributor

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

Use KeyDown event for handling MainView keyboard shortcuts to prevent handling key presses initiated in other applications. Ignoring events with KeyStatus.WasKeyDown == true to ignore key down events resulting from holding down a key.


Closes #3298

@tkohlmeier tkohlmeier changed the title use KeyDown instead of KeyUp to prevent handling key press events ini… Use KeyDown instead of KeyUp to handle MainView keyboard shortcuts Feb 25, 2025
@marticliment marticliment merged commit 6bd2400 into marticliment:main Feb 26, 2025
@tkohlmeier tkohlmeier deleted the keydown branch February 26, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UniGetUI reacts to key press although not focused
2 participants