Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quotes are incorrectly matched sometimes #711

Closed
Vintodrimmer opened this issue Jun 8, 2018 · 4 comments
Closed

Double quotes are incorrectly matched sometimes #711

Vintodrimmer opened this issue Jun 8, 2018 · 4 comments

Comments

@Vintodrimmer
Copy link

Good day,

As you can see in the screenshot, wrong quotes are highlighted. If I select previous or next quotation mark, the match will be correct. Is this intended behaviour?

screenshot

@PuercoPop
Copy link
Contributor

@Vintodrimmer Could you share the file in a gist? Can't reproduce locally

@Vintodrimmer
Copy link
Author

@PuercoPop I don't have that particular config anymore, but this one shows the same issue when you select the second quote on the 6th line.
The issue is present when run as root, that has a default visrc.lua.
screenshot

@5jqk2ymwqd
Copy link

In my limited testing this happens with tabs but not with spaces. The filetype doesn't seem to matter. Trivial strings e.g. "this"\t"is"\t"a"\t"test" reproduce the issue.

@martanne
Copy link
Owner

Having merged #716 this particular case involving tabs should now work. However, the whole heuristic based approach is still very simplistic and fundamentally flawed. A proper solution would need to take the language semantics into account. See also #721, #668 and #714 for discussion/complaints about syntax highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants