Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the footnote in markdown syntax[^1] does not working properly #350

Closed
GXY2017 opened this issue Jan 12, 2023 · 1 comment
Closed

the footnote in markdown syntax[^1] does not working properly #350

GXY2017 opened this issue Jan 12, 2023 · 1 comment
Labels
better-for-plugin It should be better as Marpit plugin duplicate This issue or pull request already exists

Comments

@GXY2017
Copy link

GXY2017 commented Jan 12, 2023

Version of Marp Tool

marp for vs code

Operating System

Windows

Environment

VS Code Version: 1.74.3 (user setup)
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

How to reproduce

This is a usual markdown footnote

## try footnote, this line shows normal. But the click takes you to an error page.  [^1]

[^1]: this is the page: https://file+.vscode-resource.vscode-cdn.net/c%3A/Users/xxx/Marp_Basic/

Expected behavior

show the footnotes on the slide.

Actual behavior

  1. it opens a page in browser.
  2. no footnotes on the slides.
  3. the [^1] in content does not hop up to the right corner.

Additional information

No response
@GXY2017 GXY2017 added the bug Something isn't working label Jan 12, 2023
@yhatt yhatt added better-for-plugin It should be better as Marpit plugin and removed bug Something isn't working labels Jan 12, 2023
@yhatt
Copy link
Member

yhatt commented Jan 12, 2023 •
edited
Loading

Duplicate of marp-team/marp#150.

Marpit respects CommonMark spec that have no footnote support. Make and use a Marpit/markdown-it plugin for footnotes.

Marpit and Marp Core must follow CommonMark, and footnote is not part of CommonMark so we have not any plan for built-in support. Marp team has a policy that we should not break CommonMark as far as possible.

We have well-documented Marpit API to help making third-party plugins by our community. I wish that community develops and provides Marpit plugin for footnote per each slides.

— marp-team/marp-cli#226

@yhatt yhatt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
@yhatt yhatt added the duplicate This issue or pull request already exists label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better-for-plugin It should be better as Marpit plugin duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yhatt @GXY2017