Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable resizing inline image by percentage #193

Open
yhatt opened this issue Sep 20, 2019 · 2 comments
Open

Enable resizing inline image by percentage #193

yhatt opened this issue Sep 20, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Sep 20, 2019

Percentage value such as width:100% was not supported caused by a special case of in-place DOM update in Firefox (#62). But certainly I think percentage should be enabled in an inline image too.

Originally posted by @yhatt in #192 (comment)
@yhatt yhatt added the enhancement New feature or request label Sep 20, 2019
@varac
Copy link

varac commented Jul 8, 2020

I'd like to second this, since I find it the most missing feature of marp. Which is awesome tool btw, thanks for it !

@yhatt yhatt added this to the Marpit v2 (modified) milestone Sep 20, 2020
@yhatt yhatt removed this from the Marpit v2 (modified) milestone Mar 25, 2021
@yhatt
Copy link
Member Author

yhatt commented Sep 19, 2021 •
edited
Loading

I have not been able to verbalize why Marpit does not support image resize by percentage. Now marp-team/marp#167 (reply in thread) is pointing out a strange and counterintuitive rendering caused by resizing by percentage value(s).

2021-09-19.14.53.05.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varac @yhatt