Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Marp CLI configuration support for trusted workspace #194

Closed
yhatt opened this issue Feb 6, 2021 · 7 comments
Closed

Custom Marp CLI configuration support for trusted workspace #194

yhatt opened this issue Feb 6, 2021 · 7 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@yhatt
Copy link
Member

yhatt commented Feb 6, 2021

VS Code team is working now for creation trusted workspace concept: microsoft/vscode#106488

Marp for VS Code has not allowed custom Marp CLI configuration for preview and export by default, to prevent some malicious (#85, #121). By permitting the reference to custom configuration in trusted workspace, the usage of custom configuration and engine could make safer.

Related: #121, #123

@yhatt yhatt added enhancement New feature or request upstream Depended on upstream labels Feb 6, 2021
@yhatt yhatt removed the upstream Depended on upstream label May 5, 2021
@yhatt
Copy link
Member Author

yhatt commented May 5, 2021

@Serenade600
Copy link

Is there any ETA of this feature?

@yhatt
Copy link
Member Author

yhatt commented May 20, 2021

At least it requires to wait for fully adopting Workspace Trust in the stable VS Code.

@ruifengx
Copy link

ruifengx commented Oct 6, 2021

It seems the latest relevant PR concerning Workspace Trust is merged on July 11. So is there any ongoing effort on implementing this feature, if I may ask? I'd be more than happy to contribute on this feature, but of course not to duplicate someone else's work.

@yhatt
Copy link
Member Author

yhatt commented Oct 6, 2021

Workspace trust's security model seems not fully to merge into Markdown preview yet. microsoft/vscode#131939

And we still have not decided a primary approach to extend Markdown syntax for preview and exported output. We have thought the approach of using Marp CLI config in this issue, but an another approach has suggested in marp-team/marp#176: Adopt the same mental model as existing VS Code Markdown extensions.

@sedyh
Copy link

sedyh commented Jun 12, 2023

Hello. Is there any activity on this?

@yhatt yhatt added the wontfix This will not be worked on label Jun 12, 2023
@yhatt
Copy link
Member Author

yhatt commented Jun 12, 2023

Close as wontfix due to the potential security issue. You still can discuss about possibility of extend the engine at marp-team/marp#176.

@yhatt yhatt closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants