-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Marp CLI configuration support for trusted workspace #194
Comments
Is there any ETA of this feature? |
At least it requires to wait for fully adopting Workspace Trust in the stable VS Code. |
It seems the latest relevant PR concerning Workspace Trust is merged on July 11. So is there any ongoing effort on implementing this feature, if I may ask? I'd be more than happy to contribute on this feature, but of course not to duplicate someone else's work. |
Workspace trust's security model seems not fully to merge into Markdown preview yet. microsoft/vscode#131939 And we still have not decided a primary approach to extend Markdown syntax for preview and exported output. We have thought the approach of using Marp CLI config in this issue, but an another approach has suggested in marp-team/marp#176: Adopt the same mental model as existing VS Code Markdown extensions. |
Hello. Is there any activity on this? |
Close as wontfix due to the potential security issue. You still can discuss about possibility of extend the engine at marp-team/marp#176. |
VS Code team is working now for creation trusted workspace concept: microsoft/vscode#106488
Marp for VS Code has not allowed custom Marp CLI configuration for preview and export by default, to prevent some malicious (#85, #121). By permitting the reference to custom configuration in trusted workspace, the usage of custom configuration and engine could make safer.
Related: #121, #123
The text was updated successfully, but these errors were encountered: