Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The punycode module is deprecated (when installed via Homebrew). #596

Closed
MichaelCharles opened this issue Sep 24, 2024 · 1 comment
Closed

Comments

@MichaelCharles
Copy link

Version of Marp Tool

@marp-team/marp-cli v3.4.0 (w/ @marp-team/marp-core v3.9.0)

Operating System

macOS

Environment

  • OS version: macOS Sequoia 15
  • Node.js version (Marpit / Marp Core/ Marp CLI): Reproduced with both v18.20.4 and v20.17.0 installed globally. I think that since this was installed with Homebrew, the globally installed Node version is unrelated.
  • VS Code version (Marp for VS Code): Not relevant.
  • Homebrow Version: 4.3.24

How to reproduce

Install marp-cli via Homebrew: brew install marp-cli

Execute any command,

➜ marp --html presen.md
(node:37034) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:37034) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
[  INFO ] Converting 1 markdown...
[  INFO ] presen.md => presen.html

Expected behavior

I expect that deprecation warnings will not show.

Actual behavior

Deprecation warnings show.

Additional information

This seems to have been already resolved here, and if I install marp-cli via npm install -g @marp-team/marp-cli rather than via brew install marp-cli, even though the versions are identical (@marp-team/marp-cli v3.4.0 (w/ @marp-team/marp-core v3.9.0)) I do not get the deprecation warning. The deprecation warning only appears when installed via Homebrew.

@MichaelCharles MichaelCharles changed the title The punycode module is deprecated (When installed via Homebrew). The punycode module is deprecated (when installed via Homebrew). Sep 24, 2024
@yhatt
Copy link
Member

yhatt commented Sep 24, 2024

I think that since this was installed with Homebrew, the globally installed Node version is unrelated.

It is actually related because Homebrew's Marp formula is depending on node formula. Homebrew will install the latest version v22 instead of recommended LTS Node.js version v20. So if the result of node -v is v22.x.x, deprecation warnings may be shown.

That will be fixed by #591, that is going to include in next release Marp CLI v4 (CHANGELOG). Basically, you don't need to care their deprecations for now, but try to install Node.js LTS if you concerned.

@yhatt yhatt closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants