ReferenceManyCount renders a corrupted link

[riffbyte]

What you were expecting:
When used with link prop, ReferenceManyCount should render a clickable link that leads to the filtered resource page

What happened instead:
The link is rendered as span tag with to attribute set to [object Object].

Steps to reproduce:
It is actually reproducible on the simple example straight out of the box. Just click "inspect" on any "Nb comment" field in Posts grid.

Other information:
This is easily fixable by removing a single line:

react-admin/packages/ra-ui-materialui/src/field/ReferenceManyCount.tsx

Line 82 in 1a1b80a

component="span"

I've filed a PR with the proposed change: #8752

I don't think using span was intended, probably just flowed over from Typography component props below.

Environment

• React-admin version: 4.6.2
• React version: 18.2.0
• Browser: Chrome

[slax57]

Reproduced, thanks!

[slax57]

Sorry @oleg-semyonov I did not see you had already opened a PR for this issue.
Mine has the advantage of allowing to remove the // @ts-ignore for good so I'd recommend keeping this one over yours.
Still grateful for the report and the PR though! 🙏

[riffbyte]

Wow, thanks for such a quick response!

I checked your PR, and indeed that's a much more permanent solution. I closed my PR in favor of yours.

[slax57]

@oleg-semyonov plot twist: #8754 (comment) actually gives arguments in favor of your PR 😁
Would you like to reopen it? (seems like I can't do it myself)
Sorry for the time loss 😅

[riffbyte]

Re-opened the PR! Please check my solution for the @ts-ignore directive. It might be a breaking change as well, but it seems to me that the way I did is what it supposed to be in the first place 🤔

[slax57]

It looks good to me, thanks!