Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UrlField click cancelled by datagrid rowclick #8707

Closed
fzaninotto opened this issue Mar 6, 2023 · 0 comments · Fixed by #8708
Closed

UrlField click cancelled by datagrid rowclick #8707

fzaninotto opened this issue Mar 6, 2023 · 0 comments · Fixed by #8708
Labels
bug

Comments

@fzaninotto
Copy link
Member

What you were expecting:

In a <Datagrid rowClick="edit">, when using a UrlField, clicking on the URL should link to the URL target

What happened instead:

It leads to the edit view instead

Related code:

EmailField cancels the click propagation:

react-admin/packages/ra-ui-materialui/src/field/EmailField.tsx

Line 34 in e9214c1

onClick={stopPropagation}

We should do the same on UrlField

Environment

  • React-admin version: 4.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix <UrlField> click is cancelled by Datagrid's row click marmelab/react-admin
1 participant
@fzaninotto