Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayInput>SimpleFormIterator labels not working #7631

Closed
RWOverdijk opened this issue May 4, 2022 · 2 comments · Fixed by #7641
Closed

ArrayInput>SimpleFormIterator labels not working #7631

RWOverdijk opened this issue May 4, 2022 · 2 comments · Fixed by #7641
Labels

Comments

@RWOverdijk
Copy link
Contributor

RWOverdijk commented May 4, 2022

What you were expecting:

Labels on inputs.

What happened instead:

No labels on inputs.

Steps to reproduce:

ArrayInput with SimpleFormIterator nested, with Inputs nested: no labels.

https://codesandbox.io/s/github/marmelab/react-admin/tree/master/examples/simple?file=/src/posts/PostCreate.tsx

Related code:

https://codesandbox.io/s/github/marmelab/react-admin/tree/master/examples/simple?file=/src/posts/PostCreate.tsx

Other information:

This time I don't have to create a reproducible example because it's part of the example itself already.

It's the ArrayInput>SimpleFormIterator for Backlinks (the sandbox links should go to the correct file)

image

Environment

  • React-admin version: master
  • React version: whatever is on master
@djhi
Copy link
Collaborator

djhi commented May 5, 2022

Reproduced. Thanks for reporting this. Besides, the label translation key looks wrong as it should probably be something like resources.posts.fields.backlinks.date and resources.posts.fields.backlinks.url

@djhi
Copy link
Collaborator

djhi commented May 5, 2022

Note however that if you pass have a translation for the current key, it will be used for the label. the bug only occurs when you rely on our defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants