Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelling in DatagridRow component #3081

Closed
romakv4 opened this issue Apr 2, 2019 · 3 comments
Closed

Misspelling in DatagridRow component #3081

romakv4 opened this issue Apr 2, 2019 · 3 comments
Labels

Comments

@romakv4
Copy link

romakv4 commented Apr 2, 2019

Hi! I have found misspelling in the method coomponentDidUpdate of the component DatagridRow.

According to react documentation the name should be componentDidUpdate.
I am newbie in the react admin so i am not sure should it be renamed or just deleted.

Related code:

coomponentDidUpdate = (prevProps, prevState) => {

@djhi
Copy link
Collaborator

djhi commented Apr 2, 2019

😆 This is a good one! Would you mind making a pull request to fix it ? Thanks!

@djhi djhi added the bug label Apr 2, 2019
@romakv4
Copy link
Author

romakv4 commented Apr 2, 2019

Ok, I will fix it.

@Kmaschta
Copy link
Contributor

Kmaschta commented Apr 3, 2019

May I suggest that we add a test on this behavior too? Because it can't works that way :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants