Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code arm required #46

Closed
pergolafabio opened this issue Jun 5, 2024 · 22 comments
Closed

Code arm required #46

pergolafabio opened this issue Jun 5, 2024 · 22 comments

Comments

@pergolafabio
Copy link

Hey, I see in the bete release notes a breaking change for the alarm panel, is it possible to add this value as an option? I don't want to use a code to arm/disarm...

https://developers.home-assistant.io/blog/2024/05/22/alarm_control_panel_validation/

@pergolafabio
Copy link
Author

hey @markxroberts .... I updated indeed to 2026.6
and the alarm panel was failing, since no code was setup, i had to define a default code, maybe an option to turn of the code_arm_required in your addon?

image

@markxroberts
Copy link
Owner

Well spotted. I didn't notice that it was a breaking change.

There's no facility to validate the code against the panel. The easiest option is for me to specify code_alarm_required: false in the registration packet.

If I put it in as an option, I'll have to validate it in the add-on, which doesn't seem right. Is that OK? If you say yes, I'll try to release an update later.

@pergolafabio
Copy link
Author

indeed, code_alarm_required: false, is perfect :-)
i have now setup a default code in the alarm panel, otherwhise it wasnt working anymore

@markxroberts
Copy link
Owner

Should be closed by #47, release 2024.6.1

@pergolafabio
Copy link
Author

Great! :-)

@pergolafabio
Copy link
Author

Hey, i saw some updates, thnx
@markxroberts , any idea why the lovelace alarm panel card is now presenting a keycode pad?

Never had this before :-(

image
image

@markxroberts
Copy link
Owner

Which add-on version is that?

@pergolafabio
Copy link
Author

I'm running latest version, updated yesterday, but not sure if it's addon related

@markxroberts
Copy link
Owner

2024.6.2 only released this morning. Could be an issue with the earlier version, but as no code specified in that one, seems less likely, especially as the configuration you shared is code_arm_required: false.

@pergolafabio
Copy link
Author

Yeah, nor sure what's going on :-(

@pergolafabio
Copy link
Author

Seems there is also "code_disarm_required" , maybe that one is needed to for "false" setting to hide the new keypad?
see here:

home-assistant/core#119443

@markxroberts
Copy link
Owner

Both "code_arm_required": false and "code_disarm_required": false are already present in the HA autodiscovery message for the partitions from 2024.6.1 onwards.

@pergolafabio
Copy link
Author

ah, but i only see this one: code_arm_required: false

image

@markxroberts
Copy link
Owner

You may need to update to the latest version. I can't remember when I noticed that both entries were required.

@pergolafabio
Copy link
Author

Just updated, but still a keypad, still notice only: code_arm_required

@markxroberts
Copy link
Owner

Can you pls share the MQTT autodiscovery message using MQTT explorer or equivalent

@pergolafabio
Copy link
Author

hmm, seems its there, but i dont see it, even after restarting the addon

{"name":"Pergola Quintens","object_id":"risco-alarm-panel-1","state_topic":"risco-alarm-panel/alarm/partition/1/status","unique_id":"risco-alarm-panel-partition-1","availability_mode":"all","availability":[{"topic":"risco-alarm-panel/alarm/status"},{"topic":"risco-alarm-panel/alarm/button_status"}],"payload_disarm":"disarmed","payload_arm_away":"armed_away","payload_arm_home":"armed_home","payload_arm_night":"armed_home","payload_arm_vacation":"armed_away","payload_arm_custom_bypass":"armed_home","code_arm_required":false,"code_disarm_required":false,"code":XXX,"device":{"manufacturer":"Risco","model":"LightSys/RP432","name":"Risco Alarm","sw_version":"2.70","identifiers":"risco-alarm-panel"},"command_topic":"risco-alarm-panel/alarm/partition/1/set"}

image

@pergolafabio
Copy link
Author

tried deleting the mqtt device and restarted addon, to start clean, but didnt make any difference
but i still dont know if it will fix the keypad issue at the end

@markxroberts
Copy link
Owner

This is interesting and I suspect might be an unanticipated front end issue. Here are some examples from my system. I have the alarm control panel card and the mushroom card to show the variation. The Risco Alarm Garage discovery message uses the new format autodiscovery message. The greenhouse dripper uses the old format autodiscovery message. Both show code_arm_required: true under Developer Tools ->states. Greenhouse dripper just gives an error message when you click the arm button. Risco alarm garage shows the keypad whether armed or disarmed. The mushroom card shows the same format for both types of autodiscovery message. You're right - I don't think we can fix this!

image

@pergolafabio
Copy link
Author

ok, yeah, it started happening since 2024.6.x , i try to keep away from custom cards if not needed :-)
maybe i can hide it with card-mod

@pergolafabio
Copy link
Author

found this on forum, working for now :-)

          - type: alarm-panel
            entity: alarm_control_panel.risco_alarm
            card_mod:
              style: |
                  #keypad {display: none !important;}
                  ha-textfield {display: none !important;}

@pergolafabio
Copy link
Author

Hey, thnx for updating this addon!! Really like it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants