Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of de_ancient to the list of pre-defined map translations #294

Closed
luke1337go opened this issue Jun 3, 2021 · 2 comments
Closed

Comments

@luke1337go
Copy link

Hi!
Would be nice if you could add de_ancient to your "list of pre-defined map translations" of the official maps, so that other applications can rebuild and update with the new map.
Thank you for your effort, have a good day!
Luke

@markus-wa
Copy link
Owner

Hi Luke, I'll see if I can get around to this soon ™️

The whole metadata stuff probably needs updating anyway as maps will have changed (last actual changes to scales etc was 3 years ago, yikes!)

Note that it's pretty easy to override, change and add maps by going somthing like

metadata.MapNameToMap["de_ancient"] = metadata.Map{
  Name: "de_ancient",
  PZero: r2.Point{X: ..., Y: ...},
  Scale: ...,
}

Needs a bit of fiddling to get the scaling right but this example can be a good testing ground: https://github.com/markus-wa/demoinfocs-golang/tree/master/examples/heatmap

I also have some interesting ideas to automate all of this going forward but I'm not sure if/when I'll get to that (and not sure it would be part of this library).

I'm also always more than happy to review and approve any PR for this, so if you'd like to have a go please do 🙂 - that's probably the quickest path to get this in.

@markus-wa
Copy link
Owner

thanks to @srjnm 's PR #302 we've now got this in.

I also learned that these translations are much easier to get than just manually trying every possible value 😅 so I've added cs_office and cs_agency as a bonus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants