Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly differntiate Dot- and Color groups #5

Open
markus-k opened this issue Aug 4, 2023 · 0 comments
Open

Properly differntiate Dot- and Color groups #5

markus-k opened this issue Aug 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@markus-k
Copy link
Owner

markus-k commented Aug 4, 2023

Dot Groups (user-selectable) and Color Groups (fixed current sinks) are currently a bit mixed up.

  • DotGroup should have the None option removed and set_dot_groups should take an Option<DotGroup> instead.
  • The Group enum should be renamed to ColorGroup, and possibly their items renamed to Red, Green, Blue (altough there is no electrical reason these have to be these specific colors, which could be confusing).
  • set_group_current should be renamed to set_color_group_current.
  • set_group_brightness should take a DotGroup and be renamed to set_dot_group_brightness.

Thses changes should make the differences between fixed color groups and user selectable dot groups clearer, as the datasheet itself it not always super clear on that end.

@markus-k markus-k self-assigned this Aug 4, 2023
@markus-k markus-k added the enhancement New feature or request label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant