You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dot Groups (user-selectable) and Color Groups (fixed current sinks) are currently a bit mixed up.
DotGroup should have the None option removed and set_dot_groups should take an Option<DotGroup> instead.
The Group enum should be renamed to ColorGroup, and possibly their items renamed to Red, Green, Blue (altough there is no electrical reason these have to be these specific colors, which could be confusing).
set_group_current should be renamed to set_color_group_current.
set_group_brightness should take a DotGroup and be renamed to set_dot_group_brightness.
Thses changes should make the differences between fixed color groups and user selectable dot groups clearer, as the datasheet itself it not always super clear on that end.
The text was updated successfully, but these errors were encountered:
Dot Groups (user-selectable) and Color Groups (fixed current sinks) are currently a bit mixed up.
DotGroup
should have theNone
option removed andset_dot_groups
should take anOption<DotGroup>
instead.Group
enum should be renamed toColorGroup
, and possibly their items renamed to Red, Green, Blue (altough there is no electrical reason these have to be these specific colors, which could be confusing).set_group_current
should be renamed toset_color_group_current
.set_group_brightness
should take aDotGroup
and be renamed toset_dot_group_brightness
.Thses changes should make the differences between fixed color groups and user selectable dot groups clearer, as the datasheet itself it not always super clear on that end.
The text was updated successfully, but these errors were encountered: