Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra event handlers are getting added when noConflict js containing marko widgets is loaded #175

Open
ctdio opened this issue Mar 29, 2017 · 0 comments

Comments

@ctdio
Copy link

ctdio commented Mar 29, 2017

Hey, sorry to open up an issue on a legacy module, especially since v4 is already here.

I've been seeing issues with extra event handlers being added when we lazily load one of our scripts onto a page that already has marko v3 components on the page. Once the script is loaded, all button clicks on our page end up firing twice, causing some problems for our test automation team.

I managed to isolate the issue and pushed it to this repo:
https://github.com/charlieduong94/marko-widgets-double-events-issue

The issue seems to be because of lasso's noConflict option. Removing the option would fix the issue for us, but because of the nature of our api, we need to have that enabled to ensure that we don't clash with any other code out in the wild.

Note: this problem only seems to be an issue with marko v3 and marko widgets. I tried to reproduce the issue with marko v4, but things seem to work fine.

(To be honest, I just want to move my team to v4, but we can't do that yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant