From 82d2620d5022f9677798b20ef74972d9d8960c8a Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov.ru@gmail.com>
Date: Tue, 11 Oct 2022 15:00:12 +0000
Subject: [PATCH] Code Modernization: Add `AllowDynamicProperties` attribute to
 recently introduced classes.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit is a follow-up to [54133] for new classes introduced in WordPress 6.1 since the previous commit.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

There are a number of ways to mitigate this:
* If it is an accidental typo for a declared property: fix the typo.
* For known properties: declare them on the class.
* For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in.
* For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes.

Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1.

To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, the `#[AllowDynamicProperties]` attribute has been added to all “parent” classes in WP.

Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties].

Follow-up to [53922], [54133].

Props jrf.
See #56513, #56034.
Built from https://develop.svn.wordpress.org/trunk@54481


git-svn-id: http://core.svn.wordpress.org/trunk@54040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-includes/class-wp-theme-json-data.php                        | 1 +
 .../style-engine/class-wp-style-engine-css-declarations.php     | 1 +
 wp-includes/style-engine/class-wp-style-engine-css-rule.php     | 1 +
 .../style-engine/class-wp-style-engine-css-rules-store.php      | 1 +
 wp-includes/style-engine/class-wp-style-engine-processor.php    | 1 +
 wp-includes/style-engine/class-wp-style-engine.php              | 1 +
 wp-includes/version.php                                         | 2 +-
 7 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/wp-includes/class-wp-theme-json-data.php b/wp-includes/class-wp-theme-json-data.php
index 089e65eddb6..9ffa2f35857 100644
--- a/wp-includes/class-wp-theme-json-data.php
+++ b/wp-includes/class-wp-theme-json-data.php
@@ -10,6 +10,7 @@
 /**
  * Class to provide access to update a theme.json structure.
  */
+#[AllowDynamicProperties]
 class WP_Theme_JSON_Data {
 
 	/**
diff --git a/wp-includes/style-engine/class-wp-style-engine-css-declarations.php b/wp-includes/style-engine/class-wp-style-engine-css-declarations.php
index 0b9eb59a15a..23efd6a40cc 100644
--- a/wp-includes/style-engine/class-wp-style-engine-css-declarations.php
+++ b/wp-includes/style-engine/class-wp-style-engine-css-declarations.php
@@ -16,6 +16,7 @@
  *
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_CSS_Declarations {
 
 	/**
diff --git a/wp-includes/style-engine/class-wp-style-engine-css-rule.php b/wp-includes/style-engine/class-wp-style-engine-css-rule.php
index 6e534181212..53225d7d65a 100644
--- a/wp-includes/style-engine/class-wp-style-engine-css-rule.php
+++ b/wp-includes/style-engine/class-wp-style-engine-css-rule.php
@@ -16,6 +16,7 @@
  *
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_CSS_Rule {
 
 	/**
diff --git a/wp-includes/style-engine/class-wp-style-engine-css-rules-store.php b/wp-includes/style-engine/class-wp-style-engine-css-rules-store.php
index 9b1ed7e7063..235fe53e920 100644
--- a/wp-includes/style-engine/class-wp-style-engine-css-rules-store.php
+++ b/wp-includes/style-engine/class-wp-style-engine-css-rules-store.php
@@ -16,6 +16,7 @@
  *
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_CSS_Rules_Store {
 
 	/**
diff --git a/wp-includes/style-engine/class-wp-style-engine-processor.php b/wp-includes/style-engine/class-wp-style-engine-processor.php
index 8e035b59ee7..241437b2043 100644
--- a/wp-includes/style-engine/class-wp-style-engine-processor.php
+++ b/wp-includes/style-engine/class-wp-style-engine-processor.php
@@ -16,6 +16,7 @@
  *
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_Processor {
 
 	/**
diff --git a/wp-includes/style-engine/class-wp-style-engine.php b/wp-includes/style-engine/class-wp-style-engine.php
index c6554c5dd97..951dac4b543 100644
--- a/wp-includes/style-engine/class-wp-style-engine.php
+++ b/wp-includes/style-engine/class-wp-style-engine.php
@@ -21,6 +21,7 @@
  * @access private
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 final class WP_Style_Engine {
 	/**
 	 * Style definitions that contain the instructions to
diff --git a/wp-includes/version.php b/wp-includes/version.php
index 4f19591b866..55fa82bb299 100644
--- a/wp-includes/version.php
+++ b/wp-includes/version.php
@@ -16,7 +16,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '6.1-beta3-54480';
+$wp_version = '6.1-beta3-54481';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.