Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript definitions for moment-msdate methods #22

Open
2 tasks
andymerskin opened this issue Jul 25, 2019 · 0 comments · May be fixed by #23
Open
2 tasks

Add TypeScript definitions for moment-msdate methods #22

andymerskin opened this issue Jul 25, 2019 · 0 comments · May be fixed by #23

Comments

@andymerskin
Copy link

Using moment-msdate in place of moment or moment-timezone in a TypeScript project requires type definitions for its methods. Moment + Timezone are already typed.

I'm still pretty new to TypeScript, but I may create a PR we can review and hopefully get this in.

All it may involve is (add anything I'm missing)

  • Create TS def file moment-msdate.d.ts
  • Link to package.json on typings key
@demsullivan demsullivan linked a pull request May 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Typescript type definitions demsullivan/moment-msdate
1 participant
@andymerskin